Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include absoluteRuntime in babel preset docs #5847

Merged
merged 3 commits into from
Apr 4, 2020
Merged

Include absoluteRuntime in babel preset docs #5847

merged 3 commits into from
Apr 4, 2020

Conversation

iddan
Copy link
Contributor

@iddan iddan commented Nov 17, 2018

Documented babel-preset-react-app absoluteRuntime option

@iddan
Babel preset absoluteRuntime docs
b809b36 
Documented babel-preset-react-app absoluteRuntime option
@iddan iddan mentioned this pull request Nov 17, 2018
Closed
@Timer Timer added this to the 2.1.x milestone Nov 18, 2018
@mrmckeb mrmckeb self-assigned this Dec 9, 2018
@mrmckeb
Copy link
Contributor

mrmckeb commented Dec 9, 2018

Thanks for this @iddan. Out of interest, what was the motivation for this PR? Was it an issue you faced yourself? And if so, why did you need to modify this setting?

Thanks!

@iddan
Copy link
Contributor Author

iddan commented Dec 9, 2018

If I remember correctly I stumbled upon it while trying to integrate Storybook

mrmckeb
mrmckeb suggested changes Dec 9, 2018
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iddan, two comments here - but looks good.

By the way, Storybook now works with create-react-app (including TypeScript and CSS modules (Sass included) without a custom config.

packages/babel-preset-react-app/README.md Outdated Show resolved Hide resolved
packages/babel-preset-react-app/README.md Show resolved Hide resolved
@thallada
Copy link

I think this should be merged! It turns out that this plugin was causing the contenthash for my JS bundles to change when building the exact same code between two different directories. And I didn't know about it because minification was stripping out the absolute paths from the final bundle. I'm not sure why absoluteRuntime needs to be true anyways, perhaps it should default to false instead?

See: webpack/webpack#1155 and webpack/webpack#7179

@iansu iansu modified the milestones: 2.1.x, 3.x Mar 10, 2019
@iddan @mrmckeb
Update packages/babel-preset-react-app/README.md
8b70df8 
Co-Authored-By: Brody McKee <mrmckeb@users.noreply.github.com>
@iddan
Copy link
Contributor Author

iddan commented Apr 1, 2020

Why was this not merged?

@ianschmitz ianschmitz modified the milestones: 3.x, 3.4.2 Apr 4, 2020
@ianschmitz ianschmitz requested a review from mrmckeb April 4, 2020 23:31
@ianschmitz ianschmitz changed the title Babel preset absoluteRuntime docs Include absoluteRuntime in babel preset docs Apr 4, 2020
@ianschmitz ianschmitz merged commit c7352c7 into facebook:master Apr 4, 2020
@ianschmitz
Copy link
Contributor

Sorry this got missed. Thanks @iddan.

@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@petetnt petetnt Awaiting requested review from petetnt

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

Assignees

@mrmckeb mrmckeb

Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@iddan @mrmckeb @thallada @ianschmitz @iansu @Timer @facebook-github-bot